Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash on onActivityResult if Stripe isn't initalized #255

Merged
merged 1 commit into from
May 22, 2021

Conversation

cruzach
Copy link
Collaborator

@cruzach cruzach commented May 22, 2021

Apps can crash if they haven't initialized stripe, and run code that triggers BaseActivityEventListener.onActivityResult, so the listener's content should be wrapped inside of if (::stripe.isInitialized) {

Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants