Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split apple pay address by new line #548

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

arekkubaczkowski
Copy link
Collaborator

closes #531

Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@YoQuieroDistraerlo
Copy link

Hey @arekkubaczkowski, thank you for this!
I've tested your code and what I see is as follows: 'paymentMethod' returned from 'presentApplePay' has the street correctly split in line1, line2.

However, the payment method in backend is still being created with the original street from Apple Pay (i.e., 'line1'\n'line2') and the payment intent is also still being created with the same problem.

Please note that this is important not only for logistics but also for the address checks to work properly.
Thanks again!

@arekkubaczkowski
Copy link
Collaborator Author

@YoQuieroDistraerlo can you open another issue and elaborate more about this case?

@YoQuieroDistraerlo
Copy link

@YoQuieroDistraerlo can you open another issue and elaborate more about this case?

Added #553

@thorsten-stripe thorsten-stripe mentioned this pull request Sep 2, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple Pay 'street' field with two lines not being split
3 participants