Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated the dependencies for the example app #657

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

acomley-stripe
Copy link
Contributor

No description provided.

StripeCore: 2ea9531e863ef20f191a0d61f00dedb7f061baef
StripeUICore: a0f9e40520823d34c63baec0782fc4a0c7fb7484
Yoga: 4bd86afe9883422a7c4028c00e34790f560923d6

PODFILE CHECKSUM: 32acfd4fec652a6f224d467187287782155cfbdc

COCOAPODS: 1.10.2
COCOAPODS: 1.11.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@porter-stripe porter-stripe Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI appears to be using 1.11.2. I don't think it makes much of a difference between 1.10.2 and 1.11.2, but it may be nice to introduce a Gemfile so we can specify what Cocoapods version we expect to be used. Doesn't need to be done in this PR.

https://guides.cocoapods.org/using/a-gemfile.html

https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I'll take care of this in a future PR.

@acomley-stripe acomley-stripe merged commit 4043f79 into master Oct 19, 2021
@acomley-stripe acomley-stripe deleted the acomley/run-dx-537 branch October 19, 2021 18:31
Copy link

@Cordelro86 Cordelro86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants