Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade native stripe libraries #801

Merged
merged 5 commits into from
Feb 9, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

@charliecruzan-stripe charliecruzan-stripe commented Feb 8, 2022

Summary

  • Upgrades stripe-android to v19.1.+
    • this requires us to bump the example app up to android sdk version 31
  • Upgrades stripe-ios to v21.11.1

Motivation

We're planning a release soon, so let's bump up these native dependencies to pull in bugfixes/improvements.

Testing

  • I tested this manually
  • Automated tests pass

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@@ -212,6 +212,7 @@ class StripeSdkCardView(private val context: ThemedReactContext) : FrameLayout(c
override fun onCardComplete() {}
override fun onExpirationComplete() {}
override fun onCvcComplete() {}
override fun onPostalCodeComplete() {}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a note for myself that we may want to add listeners for each of these events, not sure yet though

@charliecruzan-stripe charliecruzan-stripe marked this pull request as ready for review February 8, 2022 19:57
@charliecruzan-stripe charliecruzan-stripe merged commit b6bfec8 into master Feb 9, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan-upgrade-native-libs branch February 9, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants