-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Typescript upgrade + type audit #837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested none of this and I'm not a regular contributor, but the changes I see look great!
I love the improvements to typing, and code organization, and parameter names.
The breaking change section may need to be expanded or a migration guide provided for non-TypeScript consumers of this SDK.
55c302a
to
84dc8e1
Compare
that is really nice to see that this library is actively maintained and still evolving! I noticed a huuuge progress and it's really amazing |
Summary
typescript
to v4.4.4Motivation
Some types didn't make much sense in terms of their names, and we also had some inconsistent naming. This also made it difficult to identify bugs and add new features.
Testing
Documentation
Select one: