Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Typescript upgrade + type audit #837

Merged
merged 11 commits into from
Apr 6, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

  • Upgraded typescript to v4.4.4
  • Move to relying on modules rather than namespaces
  • Moved to just one format for describing addresses
  • Setup better naming conventions on Types
  • Fixed some Type bugs (closes Wrong type definition for presentGooglePay #799)
  • Removed unused types

Motivation

Some types didn't make much sense in terms of their names, and we also had some inconsistent naming. This also made it difficult to identify bugs and add new features.

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe changed the title [WIP] BREAKING: Typescript upgrade + type audit BREAKING: Typescript upgrade + type audit Mar 9, 2022
@charliecruzan-stripe charliecruzan-stripe marked this pull request as ready for review March 9, 2022 21:49
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@fbartho fbartho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested none of this and I'm not a regular contributor, but the changes I see look great!
I love the improvements to typing, and code organization, and parameter names.

The breaking change section may need to be expanded or a migration guide provided for non-TypeScript consumers of this SDK.

@acomley-stripe acomley-stripe removed their assignment Mar 25, 2022
@charliecruzan-stripe charliecruzan-stripe merged commit d2eb808 into master Apr 6, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan-ts-upgrade branch April 6, 2022 18:28
@arekkubaczkowski
Copy link
Collaborator

that is really nice to see that this library is actively maintained and still evolving! I noticed a huuuge progress and it's really amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type definition for presentGooglePay
4 participants