Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set cardbrand tint color for CardField #851

Merged
merged 8 commits into from
Jun 1, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

The CardBrandView tint color is only set to cardNumberEditText.hintTextColor on initialization. Since we're setting that tintColor after initializing, it doesn't trickle down to the cardbrandview. Also, CardBrandView.tintColorInt is internal, so we have to use reflection to set it. If that fails (i.e. the field name changes or something like that) we just log it and move on without crashing the app.

also simplified cardInputWidgetBinding declarations down to just one

Motivation

closes #459, + achieve parity with iOS

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe force-pushed the charliecruzan-set-cardbrandviewtint branch from 2bfac79 to 262dc83 Compare April 11, 2022 17:36
@charliecruzan-stripe charliecruzan-stripe merged commit 280ed67 into master Jun 1, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan-set-cardbrandviewtint branch June 1, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] CardField has white icon when Dark theme enabled
2 participants