fix: set cardbrand tint color for CardField #851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The CardBrandView tint color is only set to
cardNumberEditText.hintTextColor
on initialization. Since we're setting that tintColor after initializing, it doesn't trickle down to the cardbrandview. Also,CardBrandView.tintColorInt
is internal, so we have to use reflection to set it. If that fails (i.e. the field name changes or something like that) we just log it and move on without crashing the app.also simplified
cardInputWidgetBinding
declarations down to just oneMotivation
closes #459, + achieve parity with iOS
Testing
Documentation
Select one: