Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly overwrite package.json import via babel #924

Merged
merged 1 commit into from
May 5, 2022
Merged

fix: correctly overwrite package.json import via babel #924

merged 1 commit into from
May 5, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary and Motivation

#902 introduced a fix, but it didn't work because it was modifying the value of importResource and wasn't (by reference) modifying path.node.source.value

Testing

manually checked the build files

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@byCedric byCedric mentioned this pull request May 4, 2022
Merged
@charliecruzan-stripe charliecruzan-stripe marked this pull request as ready for review May 5, 2022 13:13
@charliecruzan-stripe charliecruzan-stripe merged commit 676604e into master May 5, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan-babel-import-fix branch May 5, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acomley-stripe acomley-stripe Awaiting requested review from acomley-stripe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charliecruzan-stripe