Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose 'cvc' when dangerouslyGetCardDetails is set to true #928

Merged
merged 1 commit into from
May 10, 2022
Merged

feat: expose 'cvc' when dangerouslyGetCardDetails is set to true #928

merged 1 commit into from
May 10, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

returns cvc when dangerouslyGetFullCardDetails is set to true on CardField or CardForm

Motivation

closes #903

Testing

  • I tested this manually
  • I added automated tests

checked the onCardChange and onFormComplete callbacks. cvc is present when dangerouslyGetFullCardDetails is true, and is not present otherwise

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe merged commit 57f5fd6 into master May 10, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan-expose-cvc-dangerously branch May 10, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acomley-stripe acomley-stripe Awaiting requested review from acomley-stripe

Assignees

@acomley-stripe acomley-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose CVC number in CardField when dangerouslyGetFullCardDetails=true
2 participants
@charliecruzan-stripe @acomley-stripe