fix: wrap instances of framentManager.commit (or use commitAllowingStateLoss) #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2022
skyler-stripe
approved these changes
May 9, 2022
igorgrubikj-metergram
added a commit
to igor-tiptapp/stripe-react-native
that referenced
this pull request
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To avoid the crash detailed in #887, we can move the "optional" commits over to
commitAllowingStateLoss, since it's not really a terrible event if those two commits are lost, they're essentially cleanup.The other instances are all in exposed React methods, so if we encounter this error we should resolve the promise with an error, and then the user can handle that as they wish (AKA retry)
Motivation
fixes #887
Testing
Documentation
Select one: