fix: Make CardField postal code behavior consistent on iOS and Android #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnunes-stripe
approved these changes
Jun 14, 2022
android/src/main/java/com/reactnativestripesdk/CardFieldView.kt
Outdated
Show resolved
Hide resolved
charliecruzan-stripe
deleted the
charliecruzan-fix-android-complete-cardfield-callbackl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
previously, the
completefield in theonCardChangecallback would incorrectly be set totrueif the postal code wasn't filled out on Android (not ios). This fixes that, and also implements the same behavior as ios- if the user's current device locale is a country/region without postal codes, the postal code entry isn't shown or required.Users can also override the country code by passing the
countryCodepropTesting
Documentation
Select one: