Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Never show postal code input in CardField if postalCodeEnabled=false (regardless of countryCode) #996

Merged
merged 2 commits into from
Jun 15, 2022
Merged

fix: Never show postal code input in CardField if postalCodeEnabled=false (regardless of countryCode) #996

merged 2 commits into from
Jun 15, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

Previously we'd show the postal code if the countryCode was set to a country that does require postal codes, even if postalCodeEnabled was false.

Motivation

fix small bug intro'd in 0.13.0

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

charliecruzan-stripe
charliecruzan-stripe commented Jun 15, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@charliecruzan-stripe charliecruzan-stripe merged commit 5091b09 into master Jun 15, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan-fixpostalcodecardfield branch June 15, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acomley-stripe acomley-stripe Awaiting requested review from acomley-stripe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charliecruzan-stripe