Don't lookup the listener so many times #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A tiny improvement. Found during debugging of #1575. Most notably, the `provider_exists` is called for a few different providers, and each time we do the same lookup. This is now avoided by remembering with which listener we are dealing with.
rwols
changed the title
rchl
approved these changes
Feb 20, 2021
There was a problem hiding this comment.
Unrelated to this change but while trying out this change, I've noticed that on going to next/previous diagnostics with F4/shift+F4, the popup is not always shown. I think that's because the popup is shown before the view is scrolled completely and ST closes the popup if it's not in the viewport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny improvement. Found during debugging of #1575. Most notably, the
provider_existsis called for a few different providers, and each timewe do the same lookup. This is now avoided by remembering with which
listener we are dealing with.