Handle no selection consistently #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a crash that could happen in certain scenarios and also an issue with showing the hover popup with hovering 0 offset in the view. Fixes #1645
rchl
commented
Apr 21, 2021
This reverts commit b6d1a14.
rchl
commented
Apr 22, 2021
Comment on lines
+40
to
+43
| tmp_pos = get_position(self.view, event, point) | ||
| if tmp_pos is None: | ||
| return | ||
| pos = tmp_pos |
There was a problem hiding this comment.
Had to do this "tmp" stuff because python is weird. Or lambdas rather since they don't bind the variables so the type will revert to possibly being None
rwols
reviewed
Apr 23, 2021
rwols
reviewed
Apr 23, 2021
rwols
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash that could happen in certain scenarios and also an issue
with showing the hover popup with hovering a 0 offset in the view.
Fixes #1645