Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember the cwd for plugins #1814

Merged
merged 3 commits into from
Aug 1, 2021
Merged

Remember the cwd for plugins #1814

merged 3 commits into from
Aug 1, 2021

Conversation

rwols
Copy link
Member

@rwols rwols commented Jul 31, 2021

Resolves #1788

@rwols
Copy link
Member Author

rwols commented Jul 31, 2021

@randy3k for some reason the macOS workflow cannot install package control?

@jwortmann
Copy link
Member

Thanks! Despite what I wrote in the linked issue, I think it should be possible for my usecase to derive the desired environment even with the actual working directory, i.e. workspace_folders[0].path or os.getcwd() if the on_pre_start result is None (the only thing I have to do is to check whether a corresponding metadata file exists in the directory). So if you think that it would be more useful to store the actual working directory, I guess that should be fine too.

@rwols
Copy link
Member Author

rwols commented Jul 31, 2021

So if you think that it would be more useful to store the actual working directory, I guess that should be fine too.

I think the current diff will do fine :)

@rwols rwols merged commit 836fe40 into main Aug 1, 2021
@rwols rwols deleted the feat/remember-cwd branch August 1, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could the result from AbstractPlugin.on_pre_start be stored in the session?
3 participants