Sort and select closest result for Find References in quick panel #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of the suggested enhancements from #2084 (comment).
With the setting
"show_references_in_quick_panel": trueenabled it will sort the results by URI and location and select the closest one if there is a result in the current file.Note that the sort order can be OS dependent; for example Pyright uses
file:///C:/format for Windows drive letters for files which are currently open, andfile:///c%3A/format for unopened files. We could add another step to convert from URI to filename and sort those instead, but actually I found it quite useful that currently opened files are shown at the top of the list, when sorting by URI.