Use generated types for python 38

[predragnikolic]

• Switch from using lsp_types_sublime_text_33.py to using lsp_types.py
• Update the LSP types to match the latest metaModel.schema.json
• These two helper types are now removed, because they are no longer necessary:

CompletionItemDefaults = __CompletionList_itemDefaults_Type_1
CompletionEditRange = __CompletionList_itemDefaults_editRange_Type_1

[rchl]

yeah, that's not correct. Use in to check for existance of property and not bool

[rchl]

But also this does not exclude AnnotatedTextEdit if that was your goal. You'd need to explicitly check for lack of annotationId

[predragnikolic]

Thanks, I'll push a fix next week when I get back to my laptop

[rchl]

Also, without reading the spec because I'm lazy, do we really have to filter those out?

It would be rather silly for the spec to introduce AnnotatedTextEdit and break all the existing implementations. The implementations that are not aware of the new text edit type can not automagically filter it out. I would expect there to be a client capability for this and the server only to send this new text edit type if client says that it's supported.

[predragnikolic]

Also true, I did the filtering to make pyright happy. There is probably a better way to handle this, than the way I did.

[predragnikolic]

yeah, that's not correct. Use in to check for existance of property and not bool

Thanks, this is the reason for this bug reported here #2500 (comment)

[predragnikolic]

I tried to extend the type:

- WorkspaceChanges = dict[str, tuple[list[TextEdit], Optional[int]]]
+ WorkspaceChanges = dict[str, tuple[list[TextEdit | AnnotatedTextEdit | SnippetTextEdit], Optional[int]]]

I quit from changing the code because:

• there is this error which I cant seem to figure out how to solve, and not cause type issues on other places ->

// Packages/LSP/plugin/core/edit.py:
32:17  error   Argument of type "tuple[List[TextEdit], None]" cannot be assigned to parameter "value" of type "tuple[list[TextEdit | AnnotatedTextEdit | SnippetTextEdit], int | None]" in function "__setitem__" ​Pyright
                    "tuple[List[TextEdit], None]" is incompatible with "tuple[list[TextEdit | AnnotatedTextEdit | SnippetTextEdit], int | None]"
                      Tuple entry 1 is incorrect type
                        "List[TextEdit]" is incompatible with "list[TextEdit | AnnotatedTextEdit | SnippetTextEdit]"
                          Type parameter "_T@list" is invariant, but "TextEdit" is not the same as "TextEdit | AnnotatedTextEdit | SnippetTextEdit"
                          Consider switching from "list" to "Sequence" which is covariant

AnnotatedTextEdit don't require code changes, however SnippetTextEdit do require code changes because they doesn't have newText, instead they have a snippet property. I rather not extend the PR to support SnippetTextEdit, at least not in this PR. I would leave the filtering of Text edits [edit for edit in edits if is_text_edit(edit)]. I just wanted to update the types with this PR.

[rchl]

AnnotatedTextEdit is defined as interface AnnotatedTextEdit extends TextEdit so it does include newText, same as TextEdit.

I can look into the error later.

[rchl]

I've pushed a change that should address it in a different way

[predragnikolic]

Thanks, I like the way it was addressed