Include location state in LOCATION_CHANGE payload #302
Conversation
Temporary workaround until supasate/connected-react-router#302 is merged and published
|
Is there anything I can do to help this PR to be merged? |
|
bump, can you please merge this PR? |
|
would also like the sanity introduced with this feature 🙏 at the moment you need to hard code your param matching or find an extremely over-engineered/coupled way to do that with view. |
|
@supasate any chance this can be merged in? |
| </ConnectedRouter> | ||
| </Provider> | ||
| ) | ||
| props.history.push({ pathname: '/new-location', state: { foo: 'bar' } }) |
There was a problem hiding this comment.
I removed location.key from the perimeter of this PR, as it seems to be a private API of the history package.
|
Hi @fzaninotto, sorry for keeping this long. I somehow thought it was a stale PR and forgot to re-check. LGTM with some nits for the unit test. Please rebase as well. |
fzaninotto
force-pushed
the
location-state
branch
from
fb002fb
to
f7ec16c
Compare
fzaninotto
force-pushed
the
location-state
branch
from
f7ec16c
to
6c427c2
Compare
fzaninotto
changed the title
|
Rebased |
|
LGTM. Thanks for your contribution! |
|
Awesome! Any ETA on the release of this fix? |
|
@supasate would it be possible release this fix soon? |
* 'master' of github.com:supasate/connected-react-router: Bump handlebars from 4.1.2 to 4.5.3 (#385) Bump handlebars from 4.2.0 to 4.5.3 in /examples/react-native (#386) Move immutable and seamless-immutable to peer dependencies (#390) Include location state in LOCATION_CHANGE payload (#302) Implement: Windows development capability (#378)
|
Released in 6.7.0. |
Closes #301