Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDESK-6441] Ingest rule to auto post Events or Planning #1691

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

@MarkLark86 MarkLark86 added this to the 2.6 milestone Jun 14, 2022
@petrjasek
Copy link
Member

I'm wondering if we should restrict this somehow based on application (scope). or would it make sense to allow the current one to be used for planning? or this one for regular items?

@MarkLark86
Copy link
Collaborator Author

MarkLark86 commented Jun 14, 2022

I'm wondering if we should restrict this somehow based on application (scope). or would it make sense to allow the current one to be used for planning? or this one for regular items?

I completely agree here, though this will require further changes to core. For example, at the moment we can create an ingest for ICS and select text as one of the content types. IMO, the content types for an ingest should be restricted to what the ingest feed parser can supply.

We can add this idea of scope to feed parsers (and their ingest configs), where a scope can handle certain content types. Then the rest of the ingest system can be based around this scope.

Maybe for an improvement later (in the RuleHandlers I have applied content types to their can_handler method).

@MarkLark86 MarkLark86 merged commit 4ef851a into superdesk:develop Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants