Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDCP-627] As a SD admin I like to ingest events from the Onclusive API #1692

Merged
merged 15 commits into from
Jun 30, 2022
Merged

[SDCP-627] As a SD admin I like to ingest events from the Onclusive API #1692

merged 15 commits into from
Jun 30, 2022

Conversation

GyanP
Copy link
Contributor

@GyanP GyanP commented Jun 16, 2022 •
edited
Loading

No description provided.

@GyanP GyanP requested a review from petrjasek June 17, 2022 11:11
@petrjasek petrjasek added this to the 2.6 milestone Jun 21, 2022
@GyanP GyanP marked this pull request as ready for review June 22, 2022 11:15
petrjasek
petrjasek reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@petrjasek petrjasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets always use some timeout when calling the session otherwise this might block for a long time

@GyanP
Copy link
Contributor Author

GyanP commented Jun 22, 2022

lets always use some timeout when calling the session otherwise this might block for a long time

Yup, that sounds right.

@GyanP GyanP requested a review from petrjasek June 23, 2022 13:33
petrjasek
petrjasek reviewed Jun 24, 2022
View reviewed changes
server/planning/feed_parsers/onclusive.py Show resolved Hide resolved
server/planning/feed_parsers/onclusive.py Outdated Show resolved Hide resolved
server/planning/feed_parsers/onclusive.py Outdated Show resolved Hide resolved
server/planning/feed_parsers/onclusive_tests.py Outdated Show resolved Hide resolved
server/planning/feed_parsers/onclusive_tests.py Outdated Show resolved Hide resolved
server/planning/feed_parsers/onclusive_sample.json Show resolved Hide resolved
server/planning/feed_parsers/onclusive_sample.json Show resolved Hide resolved
@petrjasek
Copy link
Member

it seems like this would actually fetch only current day right? we might need to have this configurable, in general the idea will be to ingest next x days or rather months, we're need to be able to ingest next 12 months for testing

@GyanP GyanP requested a review from petrjasek June 28, 2022 10:35
@GyanP GyanP requested a review from petrjasek June 29, 2022 13:49
@GyanP GyanP requested a review from petrjasek June 30, 2022 07:32
@GyanP GyanP merged commit 46bc80f into superdesk:develop Jun 30, 2022
@MarkLark86 MarkLark86 changed the title Planning: As a SD admin I like to ingest events from the Onclusive API [SDCP-627] [SDCP-627] As a SD admin I like to ingest events from the Onclusive API Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLark86 MarkLark86 MarkLark86 left review comments

@petrjasek petrjasek petrjasek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@GyanP @petrjasek @MarkLark86