[SDESK-6504] fix: Ignore unlock ws notification if already unlocked #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing the Editor to act as if the Event/Planning item was not locked for editing
MarkLark86
requested review from
a team and
GyanP
and removed request for
a team
petrjasek
approved these changes
Jun 28, 2022
petrjasek
approved these changes
Jun 29, 2022
MarkLark86
added a commit
to MarkLark86/superdesk-planning
that referenced
this pull request
Aug 24, 2022
…uperdesk#1694) * [SDESK-6504] fix: Ignore unlock ws notification if already unlocked This was causing the Editor to act as if the Event/Planning item was not locked for editing * Iterate pagination when getting item locks * Fallback to getting lock directly from item * Fix unit tests * Include killed Events when getting locks
MarkLark86
added a commit
that referenced
this pull request
Aug 26, 2022
…1711) * [SDESK-6504] fix: Ignore unlock ws notification if already unlocked (#1694) * [SDESK-6504] fix: Ignore unlock ws notification if already unlocked This was causing the Editor to act as if the Event/Planning item was not locked for editing * Iterate pagination when getting item locks * Fallback to getting lock directly from item * Fix unit tests * Include killed Events when getting locks * fix(e2e): After daylight savings change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing the Editor to act as if the Event/Planning item was not locked for editing