[SDCP-627] fix : Planning: As a SD admin I like to ingest events from the Onclusive API #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive API[SDCP-627]
petrjasek
reviewed
Jul 19, 2022
| @@ -101,18 +101,13 @@ def _update(self, provider, update): | |||
| logger.info("Ingesting content: {} ...".format(str(between_event_response.content)[:4000])) | |||
|
|
|||
| if hasattr(parser, "parse_http"): | |||
There was a problem hiding this comment.
are actually both options possible? imo we should limit onclusive to single parser as we do for rss
There was a problem hiding this comment.
as much as i understand, that we have to registered a feedparser in the feeding service just like rss or we should do something like:
if hasattr(parser, "parse_onclusive"):
yield (parser.parse_onclusive(content, provider))
There was a problem hiding this comment.
we can set the parser explicitly like here:
https://github.com/superdesk/superdesk-core/blob/1b3ff89a92d3cce8e1cbfe635f4c23c6e39f9a5c/superdesk/io/feeding_services/rss.py#L403
so then we know it will be using onclusive parser and the parser will have that parse_http method so that if is not needed anymore
petrjasek
approved these changes
Jul 19, 2022
MarkLark86
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.