Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDCP-638] fix: Language field of ingested event is populated but missing language blocks posting the event #1719

Merged
merged 7 commits into from
Sep 9, 2022
Merged

[SDCP-638] fix: Language field of ingested event is populated but missing language blocks posting the event #1719

merged 7 commits into from
Sep 9, 2022

Conversation

devketanpro
Copy link
Member

No description provided.

@MarkLark86 MarkLark86 added this to the 2.6 milestone Sep 8, 2022
MarkLark86
MarkLark86 reviewed Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@MarkLark86 MarkLark86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As language is a generic field it would be beneficial if it was populated in the events service, if not already defined, and not be specific to any particular ingest service

@petrjasek
Copy link
Member

we should probably do the same for planning items to be consistent

@devketanpro devketanpro removed the request for review from petrjasek September 9, 2022 05:50
@devketanpro devketanpro merged commit d5b4008 into superdesk:develop Sep 9, 2022
@MarkLark86 MarkLark86 changed the title Fix : Language field of ingested event is populated but missing language blocks posting the event [SDCP-638] [SDCP-638] fix: Language field of ingested event is populated but missing language blocks posting the event Dec 12, 2022
@devketanpro devketanpro deleted the SDCP-638 branch November 22, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLark86 MarkLark86 MarkLark86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@devketanpro @petrjasek @MarkLark86