Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDESK-6558] fix : Event links are overlapping in the preview #1725

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

devketanpro
Copy link
Member

No description provided.

Copy link
Collaborator

@MarkLark86 MarkLark86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding more custom styles (we try to avoid them if possible), we can set noLabel={false} to the <LineInput
https://github.com/superdesk/superdesk-planning/blob/develop/client/components/UI/Form/LinkInput.tsx#L165

This would solve the problem without any extra custom styles

@MarkLark86 MarkLark86 added this to the 2.5.1 milestone Oct 5, 2022
@devketanpro devketanpro merged commit a1d15c7 into superdesk:develop Oct 5, 2022
@devketanpro devketanpro deleted the SDESK-6558 branch October 11, 2022 05:12
MarkLark86 pushed a commit to MarkLark86/superdesk-planning that referenced this pull request Oct 14, 2022
…esk#1725)

* Fix : Event links are overlapping in the preview

* update nolabel's property to false
@MarkLark86 MarkLark86 added the merged Merged into release branch label Oct 14, 2022
@MarkLark86 MarkLark86 changed the title Fix : Event links are overlapping in the preview [SDESK-6558] [SDESK-6558] fix : Event links are overlapping in the preview Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Merged into release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants