Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDESK-6698] fix spike event date not showing in the UI #1732

Merged
merged 5 commits into from
Nov 22, 2022
Merged

[SDESK-6698] fix spike event date not showing in the UI #1732

merged 5 commits into from
Nov 22, 2022

Conversation

thecalcc
Copy link
Contributor

No description provided.

@MarkLark86 MarkLark86 added this to the 2.6 milestone Nov 15, 2022
MarkLark86
MarkLark86 reviewed Nov 15, 2022
View reviewed changes
client/utils/events.ts Outdated Show resolved Hide resolved
client/utils/events.ts Outdated Show resolved Hide resolved
@MarkLark86 MarkLark86 changed the title Fix spike event date not showing in the UI [SDESK-6698] fix spike event date not showing in the UI Nov 15, 2022
@MarkLark86
Copy link
Collaborator

Looks like the usage of EventScheduleSummary and getDateStringForEvent is not consistent (some pass in the entire Event, some pass in the Event schedule). The interface/usage between these all will have to be fixed up.

image
image

@MarkLark86
Copy link
Collaborator

MarkLark86 commented Nov 18, 2022 •
edited
Loading

@thecalcc There are also invalid arguments pass to getDateStringForEvent in many places, some passing the whole Event while others passing only the Event Schedule. These will need to be fixed up as well

@thecalcc thecalcc merged commit 56a015f into develop Nov 22, 2022
@petrjasek petrjasek deleted the spike-event-date-fix branch April 5, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLark86 MarkLark86 MarkLark86 approved these changes

@tomaskikutis tomaskikutis Awaiting requested review from tomaskikutis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@thecalcc @MarkLark86