[SDAAP-49] fix(events) Exception being thrown on post to the events e…

[marwoodandrew]

…ndpoint

[MarkLark86]

I think this would be more of a client error rather than an API error, so we should probably stop the client sending this data rather than supporting the client to send invalid data.

We already have code similar to this for both Events & Planning, to sanitise the request data. Might be good to extend this functionality for both on the client.

• https://github.com/superdesk/superdesk-planning/blob/develop/client/actions/events/api.ts#L620
• https://github.com/superdesk/superdesk-planning/blob/develop/client/actions/planning/api.ts#L385

And probably make it more generic, and work directly with any field that starts with a specific set of characters. i.e.

function removeFieldsStartingWith(updates: {[key: string]: Array<any> | any}, prefix: string) {
    Object.keys(updates).forEach((field) => {
        if (!Array.isArray(updates[field])) {
            if (field.startsWith(prefix)) {
                delete updates[field];
            }
        } else {
            updates[field].forEach((arrayEntry) => {
                Object.keys(arrayEntry).forEach((arrayEntryField) => {
                    if (arrayEntryField.startsWith(prefix)) {
                        delete arrayEntry[arrayEntryField];
                    }
                });
            });
        }
    });
}

Then calling it like this:

removeFieldsStartingWith(updates, '$$');

Would remove any values starting with $$ from the top level field as well as any field inside an array of values