-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDESK-6851] Refactor locking mechanism #1789
Conversation
@@ -23,7 +22,7 @@ import { | |||
getTimeZoneOffset, | |||
} from '../../utils'; | |||
|
|||
import planningApi from '../planning/api'; | |||
import planningApis from '../planning/api'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to have some more descriptive naming for this vs planningApi
, it's not obvious what's the difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't consider that naming to be a blocker, but would be good to look at it at some point imo
I completely agree. In this PR I changed all imports from |
No description provided.