Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDESK-7029] fix(ui): Show validation for CustomVocabulary fields #1845

Merged
merged 4 commits into from
Aug 24, 2023
Merged

[SDESK-7029] fix(ui): Show validation for CustomVocabulary fields #1845

merged 4 commits into from
Aug 24, 2023

Conversation

MarkLark86
Copy link
Collaborator

  • Removed redundant CustomVocabulariesFields component
  • Created specific validation function for custom vocabularies
  • Render to SelectMetaTermsInput directly instead of going through Field first
  • Fix css to show proper background colour when invalid
  • Fix EditorFieldVocabulary with showing invalid state

@MarkLark86 MarkLark86 added this to the 2.7 milestone Aug 22, 2023
@MarkLark86
Copy link
Collaborator Author

@tomaskikutis It would be ideal to replace all input fields with the UI-Framework equivalent. But I think this task should wait till v2.8 development so I continued using the custom select input for now.

tomaskikutis
tomaskikutis approved these changes Aug 23, 2023
View reviewed changes
client/validators/profile.ts Outdated Show resolved Hide resolved
client/validators/profile.ts Outdated Show resolved Hide resolved
@MarkLark86 MarkLark86 merged commit 2508e44 into superdesk:develop Aug 24, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaskikutis tomaskikutis tomaskikutis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkLark86 @tomaskikutis