Add to workflow UX improvements #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How the UI looks in both cases, a coverage that's been added to workflow and one that hasn't: 
|
|
there should be a space between labels
|
tomaskikutis
reviewed
May 2, 2024
| @@ -120,8 +123,13 @@ export class CoverageItemComponent extends React.Component<IProps, IState> { | |||
| userAssigned: null, | |||
| displayContentType: '', | |||
| coverageDateText: '', | |||
| addedToWorkflow: false, | |||
There was a problem hiding this comment.
what about using addedToWorkflow: coverage.workflow_status === COVERAGES.WORKFLOW_STATE.ACTIVE so you don't need a block below?
tomaskikutis
reviewed
May 2, 2024
| @@ -1224,7 +1224,9 @@ function getCoverageIcon( | |||
| } | |||
|
|
|||
| function getCoverageIconColor(coverage: IPlanningCoverageItem): string { | |||
| if (get(coverage, 'assigned_to.state') === ASSIGNMENTS.WORKFLOW_STATE.COMPLETED) { | |||
| if (coverage.workflow_status === COVERAGES.WORKFLOW_STATE.ACTIVE) { | |||
There was a problem hiding this comment.
shouldn't you have a different color here?
There was a problem hiding this comment.
No, fritz wants to have this one
There was a problem hiding this comment.
No, fritz wants this one
tomaskikutis
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDBELGA-799
SDESK-7252