Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visualize the (event) coverage status (Planned, On Merit) #2027

Merged
merged 2 commits into from
Jul 24, 2024
Merged

visualize the (event) coverage status (Planned, On Merit) #2027

merged 2 commits into from
Jul 24, 2024

Conversation

dzonidoo
Copy link
Contributor

SDBELGA-831

tomaskikutis
tomaskikutis reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@tomaskikutis tomaskikutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix CI

client/utils/planning.ts Outdated
@@ -1256,6 +1257,20 @@ function getCoverageWorkflowIcon(coverage: IPlanningCoverageItem): string | null
}
}

function getNewsCoverageStatusDotColor(coverage: DeepPartial<IPlanningCoverageItem>): string | null {
const newsCoverageStatus: IPlanningNewsCoverageStatus
= getCoverageNewsWorkflowState(coverage, 'news_coverage_status');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need an extra function. Use coverage.news_coverage_status

@dzonidoo dzonidoo merged commit 31451e7 into superdesk:develop Jul 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaskikutis tomaskikutis tomaskikutis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzonidoo @tomaskikutis