Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extruder page management broken in Master branch #3176

Open
nanoplane opened this issue Sep 4, 2022 · 6 comments
Open

Extruder page management broken in Master branch #3176

nanoplane opened this issue Sep 4, 2022 · 6 comments

Comments

@nanoplane
Copy link
Sponsor

What happened?

if you have a printer settings tab with multiple extruders defined, multiple extruder pages are defined and numbered sequentially from "1". save this printer settings.
if you return to the printer page and add/remove extruders, the Extruder pages on the left are mangled. see attached image

This first screenshot is before modifying the count
Screen Shot 2022-09-04 at 10 21 46 AM

This second screen shot is after modifying the count (add one extruder).
Screen Shot 2022-09-04 at 10 22 04 AM

Project file & How to reproduce

no project file required....

  1. create new printer setting
  2. add extra extruders
  3. save printer setting
  4. add or remove extra extruders..
  5. see the result.

Version

2.4.58.4

Operating system

MacOS 15

Printer model

any

@nanoplane
Copy link
Sponsor Author

The issue is in the Tab.cpp file, in the function TabPrinter::build_unregular_pages, line 3149.
at this point, if there are multiple extruders and the count is changing and it's not from_initial_build, then the value of n_before_extruders is incorrect.

This can be corrected by inserting the following before line 3149:

if (m_has_single_extruder_MM_page) {
    n_before_extruders++;
}

@nanoplane
Copy link
Sponsor Author

nanoplane commented Sep 5, 2022

Here's another sample. Created by having "Single Extruder MultiMaterial" checked and clicking the up and down arrows of the "Extruders" field multiple times.

Before:
Screen Shot 2022-09-04 at 8 55 00 PM

After:
Screen Shot 2022-09-04 at 8 55 56 PM

Also note that there's a page missing !... the "Single extruder MM setup" page is missing until you play with the number of extruders....

@nanoplane
Copy link
Sponsor Author

The Single extruder MM setup page issue is another bug...

@supermerill
Copy link
Owner

I can see the problem with the single extruder mmu.
But I don't see any problem with your second screenshot. please enter in red the problematic thing.

@nanoplane
Copy link
Sponsor Author

nanoplane commented Sep 9, 2022

Just look at the ordering of the Extruders.. and the fact that there are two entries for Extruder 3. specifically look at the second set of images rather than the first set....

@nanoplane
Copy link
Sponsor Author

nanoplane commented Sep 9, 2022

I've created a fix for this at nanoplane:extruder_tab_fix.. two functions modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants