New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ch/multi year #30

Merged

clmarmy merged 26 commits into master from ch/multi-year

Aug 14, 2024

Contributor

cleherny commented Jul 15, 2024

Add the possibility for the OD to handle multi-year images:

Several images of different years can be dl for a single tile geometry
image year is included in image metadata
label year is included in COCO files
detection year is saved
detections are assessed according to their year.

Other changes: change 'quarry" to "mineral extraction sites"

cleherny added 18 commits

May 22, 2024 08:47


          Add YEAR argument to XYZ

412b9ee


          Get tile year from label shapefile

15ef0f2


          Add exception and error

1db1ca6


          Modify tile id to avoid drop of multi-year duplicates

69522df


          Delete useless comments

9e5453e


          Add back accidentally deleted part in prepare data

f94d252


          Add t parameter to id error description

78aadcb


          Add the possibility to read t,x,y,z tiles with FOLDER

ade9a44


          Merge with master

253c644


          Remove commented line in generate tileset

384284e


          Add img_year to metadata


          Add img_year to detection

f78cd9b


          Control assessment ok

ac2ff89


          Remove some warnings

4027a70


          Correct error with year in FOLDER mode

f430f6c


          Ensure multi year option is working for diff config

7568b84


          Change 'quarry' to 'Mineral Extraction Sites'

6ab2700


          Add if year condition in assess script

cleherny requested a review from clmarmy

July 15, 2024 12:13

This comment has been minimized.

Sign in to view


          Correct error in year label

df258fd

This comment has been minimized.

Sign in to view


          Correct Errno9 Bad file descriptor

8199ca0

This comment has been minimized.

Sign in to view

cleherny added 2 commits

July 22, 2024 15:29


          Correct year img_year

9a32da4


          Correct back error year_img

f4f3991

This comment has been minimized.

Sign in to view

cleherny added 2 commits

July 30, 2024 12:12


          Correct typo in assess_detections

4a0553e


          Take into account CM review

3da9ded

This comment has been minimized.

Sign in to view

cleherny mentioned this pull request

review August 24 #31

Closed


          Update CM review comments. Assert def

e2c6448

This comment has been minimized.

Sign in to view


          Remove commented lines

c579d3e

This comment has been minimized.

Sign in to view

Contributor

clmarmy commented Aug 14, 2024

All good, thanks for the collaborative review !

clmarmy closed this

clmarmy reopened this

stdl-s-sonarqube bot commented Aug 14, 2024

E Reliability Rating on New Code (is worse than A)

Analysis Details

6 Issues

1 Bug
0 Vulnerabilities
5 Code Smells

Coverage and Duplications

No coverage information (0.00% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: swiss-territorial-data-lab_object-detector_AYZ4zWIzr7JdaaSXwexc

View in SonarQube

clmarmy approved these changes

View reviewed changes

clmarmy merged commit 7780f7f into master

2 checks passed

cleherny deleted the ch/multi-year branch

August 14, 2024 08:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet