Merge XYZ into master #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creation of the script for WMTS and adaptation of generate_tilesets.py
Renamed WMTS.py for WMTS_xyz.py, made some corrections on this script and the related adaptations to generate_tilesets.py
Changed the denomination WMTS_xyz to XYZ. Tried to ensure that the download file from the request get saved in the right format(s)
Made some minor corrections to the function check_aoi_tiles in the script generate_tilesets.py
GwenaelleSa
requested changes
Nov 14, 2022
| aoi_tiles_gdf['id']='('+aoi_tiles_gdf['id'] | ||
| if not aoi_tiles_gdf['id'].str.endswith(')').all(): | ||
| aoi_tiles_gdf['id']=aoi_tiles_gdf['id']+')' | ||
|
|
||
| return |
There was a problem hiding this comment.
Puisque j'ai modifié le code pour que l'id soit corrigé si des parenthèses manquent, faudrait-il mettre return aoi_tiles_gdf? Est-ce que cela risquerait de déranger les raise Exceptions?
There was a problem hiding this comment.
Well... should the id be badly formatted, an exception would be raised and your code wouldn't be executed.
- Do we want the code to support IDs formatted as either "(<x>, <y>, <z>)" or "<x>, <y>, <z>"?
- In which case the ID would be formatted as "<x>, <y>, <z>"?
There was a problem hiding this comment.
In the current configuration, the script does not raise an exception when the id is formatted without the parenthesis. That why we should change the function to raise an error or add the parenthesis
GwenaelleSa
approved these changes
Nov 24, 2022
cleherny
pushed a commit
that referenced
this pull request
Feb 16, 2023
Merge XYZ into master Former-commit-id: 162c0ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
MIL.py,WMS.pyandXYZ.pywere moved tomisc.py.