Define score threshold as input parameter #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The threshold score value intially hard coded in the script make-prediction.py is now defined as an input parameter in the config.yaml file
The position of the score threshold setting in the script was not correct. The threshold score set in the config file was not taken into account. Instead the value set in detectron2 config file was taken into account. The .pkl file name was correct with the score value set in the config file taken into account. The attribution of the threshold score must occur before the definition of the predictor.
acerioni
approved these changes
Jan 23, 2023
cleherny
pushed a commit
that referenced
this pull request
Feb 16, 2023
Define score threshold as input parameter Former-commit-id: 691ecfe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The threshold score value initially hard coded in the script make-prediction.py, is now defined as an input parameter in the config.yaml file.