Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality #9

Merged
merged 60 commits into from
Sep 15, 2023
Merged

Improve code quality #9

merged 60 commits into from
Sep 15, 2023

Conversation

acerioni
Copy link
Member

No description provided.

@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@acerioni
Define DEMO_MSG constant in order to avoid duplication
880a0f2
@acerioni
Introduce LabelOverflowException
7ebf10a
@acerioni
ACheck and extract x, y, z coordinates from tile IDs at once
ae79029
@acerioni
Do not ignore insecure request warnings
507ae22
@acerioni
Remove unused imports
1854473
@acerioni
Introduce and handle custom exceptions for the COCO module
35e7ae2
@acerioni
Remove unexpected argument in logger.warning call
ea530c8
@acerioni
Use specific exception instead of a generic one. Rename variables sta…
c152550 
…rting with the_
@acerioni
Introduce and handle custom exceptions. Rename variables starting wit…
5564576 
…h "the_"
@acerioni
Rename _PolyArea method as _compute_polygon_area
3b7114f
@acerioni
Remove TODO messages
0e95411
@acerioni
Introduce BadFileExtensionException and UnsupportedImageFormatException
fcc0f3f
@acerioni
Use custom exception "BadFileExtensionException"
52d0c7f
@acerioni
Rename variables in order to comply with Python naming conventions
6c1a6a0
@acerioni
Remove useless f-strings
42a4782
@acerioni
Add SCATTER_PLOT_MODE constant
925c279
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
cleherny and others added 23 commits September 11, 2023 16:24
@cleherny
Add config-prd file
badd3a9
@cleherny
Add logging.conf file
df1eacf
@cleherny
Add prepare_data.py
77280e1
@cleherny
Add prediction_filter.py script
796d25c
@cleherny
Adapt paths in config files
6c0be8a
@cleherny
Add morecantile to requirements
c55dd61
@cleherny
Add input data (label shp and AOI 2021 shp
86e5f05
@cleherny
Running version of the quarry example with packages in requirements.txt
8d7f4db
@cleherny
Correct packages version in requirements.in
8c4472c
@cleherny
Change name of prediction filter script
ce5da7a
@cleherny
Update package version in requirements.in
0fdd78a
@cleherny
Add README.md file
6ddc2f3
@cleherny
Rename config files
aace5bf
@cleherny
Fix scikit-learn version
83e0ad1
@acerioni @cleherny
Remove logging.conf file (deprecated)
e93b799
@acerioni @cleherny
Generate tiles straight in EPSG:4326
f7f57e9
@acerioni @cleherny
Improve code style for iteration over label boundaries. Avoid useless…
6877c7a 
… tile reprojection
@acerioni @cleherny
Improve code readability
7c5afe9
@acerioni @cleherny
Fix some comments and screen outputs
1a13566
@acerioni @cleherny
Improve code generating tile IDs
0dfb1ac
@acerioni @cleherny
Remove unused import (tqdm)
46c4bf1
@acerioni @cleherny
Fix tile ID format
cf98eab
@acerioni @cleherny
Comment/delete unused code
d762e87
@stdl-s-sonarqube
Copy link

Passed

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage No coverage information (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: swiss-territorial-data-lab_object-detector_AYZ4zWIzr7JdaaSXwexc

View in SonarQube

@cleherny
Copy link
Contributor

cleherny commented Sep 14, 2023 •
edited
Loading

There is a warning in the swimming pool example GE linked to the command line:
cat parcels.geojson | supermercado burn 18 | mercantile shapes | fio collect > parcels_z18_tiles.geojson
I reported it here: #17 (comment)
I also made typo corrections in the branch ch/dl_dem (PR #17)
To avoid redundant work can we close this PR and focus on PR #14 and #17?

@acerioni
Copy link
Member Author

So... #17 is now closed.
We shall treat this one (merge & close), then #14...

@cleherny can you approve this?!

cleherny
cleherny approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@cleherny cleherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will merge and close this PR.

@cleherny cleherny merged commit cb17fef into master Sep 15, 2023
1 check passed
@acerioni acerioni deleted the ac/improve-code-quality branch December 13, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleherny cleherny cleherny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
First tagged version (v1.0)
Development

Successfully merging this pull request may close these issues.
2 participants
@acerioni @cleherny