Ch/dev #1
Merged
Ch/dev #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mask sorting was performed according to the mask area, hidding the smaller mask in the mask visualisation. The option reverse has been set to True in the save_masks function
The simplified geometry parameter is added in an odd way. It has to be done in a cleaner way
GwenaelleSa
added a commit
to swiss-territorial-data-lab/proj-rooftops
that referenced
this pull request
Apr 23, 2024
Update the README and the script segment_images.py to match the changes in swiss-territorial-data-lab/segment-geospatial#1
GwenaelleSa
approved these changes
Apr 25, 2024
| @@ -251,12 +256,11 @@ def save_masks( | |||
| dtype = np.uint16 | |||
| else: | |||
| dtype = np.uint32 | |||
|
|
|||
| # Generate a mask of objects with unique values | |||
| if unique: | |||
| # Sort the masks by area in ascending order | |||
There was a problem hiding this comment.
"descending order" since you switched the sorting order.
What difference does it make?
There was a problem hiding this comment.
If the masks are sorted in ascending order by area, the larger ones are at the end of the list. When visualising the masks, the smaller ones were hidden by the larger ones. This caused problems when vectorising.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to the library
segment-geospatialwere made for the project.