Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin config widgets don't resize when their contents change #393

Closed
pjreed opened this issue Jul 6, 2016 · 1 comment
Closed

Plugin config widgets don't resize when their contents change #393

pjreed opened this issue Jul 6, 2016 · 1 comment
Assignees
@pjreed
Labels
bug

Comments

@pjreed
Copy link
Contributor

pjreed commented Jul 6, 2016

If the structure inside a plugin's config widget changes and causes the size of the widget to change as a result, the widget in the plugin list does not actually resize, which causes some odd rendering behavior. Hiding and showing the plugin will cause it to recalculate its size, but it would be nice if it happened automatically.
@pjreed pjreed added the bug label Jul 6, 2016
@pjreed pjreed self-assigned this Jul 6, 2016
pjreed added a commit to pjreed/mapviz that referenced this issue Jul 6, 2016
@pjreed
Adding a way for plugin config widgets to resize
e8153fd 
- Adding an event plugins can emit to indicate their geometry has changed
- Modifying the PCL2 plugin to use it as an example

Fixes swri-robotics#393
@pjreed
Copy link
Contributor Author

pjreed commented Jul 6, 2016

Here's an example of what the PointCloud2 plugin currently looks like after it's hidden a few of its internal widgets.
mapviz-393

pjreed added a commit to pjreed/mapviz that referenced this issue Jul 6, 2016
@pjreed
Adding a way for plugin config widgets to resize
fbb91c1 
- Adding an event plugins can emit to indicate their geometry has changed
- Modifying the PCL2 plugin to use it as an example

Fixes swri-robotics#393
@pjreed pjreed mentioned this issue Jul 6, 2016
Merged
pjreed added a commit to pjreed/mapviz that referenced this issue Jul 6, 2016
@pjreed
Adding a way for plugin config widgets to resize
b58d68e 
- Adding an event plugins can emit to indicate their geometry has changed
- Modifying the PCL2 plugin to use it as an example

Fixes swri-robotics#393

Conflicts:
	mapviz/include/mapviz/mapviz_plugin.h
	mapviz/src/mapviz.cpp
	mapviz_plugins/src/pointcloud2_plugin.cpp
pjreed added a commit to pjreed/mapviz that referenced this issue Jul 6, 2016
@pjreed
Adding a way for plugin config widgets to resize
fd37866 
- Adding an event plugins can emit to indicate their geometry has changed
- Modifying the PCL2 plugin to use it as an example

Fixes swri-robotics#393
pjreed added a commit to pjreed/mapviz that referenced this issue Jul 6, 2016
@pjreed
Adding a way for plugin config widgets to resize
18adc52 
- Adding an event plugins can emit to indicate their geometry has changed
- Modifying the PCL2 plugin to use it as an example

Fixes swri-robotics#393
This was referenced Jul 6, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjreed pjreed

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjreed