Merge pull request #487 from isuruf/subs-except

Mark subs as throwing exceptions
symengine · Aug 12, 2024 · fa9d699 · fa9d699
2 parents 9ce6c5a + 8f6f7a3
commit fa9d699
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/symengine/lib/symengine.pxd b/symengine/lib/symengine.pxd
@@ -168,9 +168,9 @@ cdef extern from "<symengine/basic.h>" namespace "SymEngine":
     void cse(vec_pair &replacements, vec_basic &reduced_exprs, const vec_basic &exprs) except+ nogil
 
 cdef extern from "<symengine/subs.h>" namespace "SymEngine":
-    rcp_const_basic msubs (rcp_const_basic &x, const map_basic_basic &x) nogil
-    rcp_const_basic ssubs (rcp_const_basic &x, const map_basic_basic &x) nogil
-    rcp_const_basic xreplace (rcp_const_basic &x, const map_basic_basic &x) nogil
+    rcp_const_basic msubs (rcp_const_basic &x, const map_basic_basic &x) except+ nogil
+    rcp_const_basic ssubs (rcp_const_basic &x, const map_basic_basic &x) except+ nogil
+    rcp_const_basic xreplace (rcp_const_basic &x, const map_basic_basic &x) except+ nogil
 
 cdef extern from "<symengine/derivative.h>" namespace "SymEngine":
     rcp_const_basic diff "SymEngine::sdiff"(rcp_const_basic &arg, rcp_const_basic &x) except+ nogil

diff --git a/symengine/tests/test_subs.py b/symengine/tests/test_subs.py
@@ -1,7 +1,7 @@
 import unittest
 
 from symengine.test_utilities import raises
-from symengine import Symbol, sin, cos, sqrt, Add, function_symbol, have_numpy
+from symengine import Symbol, sin, cos, sqrt, Add, function_symbol, have_numpy, log
 
 
 def test_basic():
@@ -24,6 +24,12 @@ def test_sin():
     assert e.subs(x, 0) == 1
 
 
+def test_subs_exception():
+    x = Symbol("x")
+    expr = sin(log(x))
+    raises(RuntimeError, lambda: expr.subs({x: 0}))
+
+
 def test_args():
     x = Symbol("x")
     e = cos(x)