Wrapped as_real_imag #217
Merged
Wrapped as_real_imag #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npochhi
force-pushed
the
as-real-imag
branch
from
fcef414
to
6d8b4cc
Compare
|
ping @isuruf |
isuruf
reviewed
Feb 10, 2018
symengine/tests/test_arit.py
Outdated
| @@ -165,6 +165,11 @@ def test_as_numer_denom(): | |||
| assert x == Integer(-5) | |||
| assert y == Integer(1) | |||
|
|
|||
| def test_as_real_imag(): | |||
| x, y = (Integer(5) + Integer(6) * I).as_real_imag() | |||
There was a problem hiding this comment.
Use 5 + 6 * I. Integer is not necessary here and not necessary in the lines below
npochhi
force-pushed
the
as-real-imag
branch
from
6d8b4cc
to
3646c8a
Compare
isuruf
approved these changes
Feb 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210