Cython3 support #444
Merged
Cython3 support #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mgorny |
thilinarmtb
approved these changes
Jun 15, 2023
|
Well done on finding a workaround @isuruf. If we had unlimited time resources I guess we would come up with something else, but this looks like the simplest fix to me. :) |
bjodah
approved these changes
Jun 24, 2023
|
Maybe we should add a CI-job which explicitly runs with |
This reverts commit a5974ea.
|
New CI uses cython3 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major change is in d4ca69f which is a workaround to Cython3 deprecating
the support for translation time constant conditional statements.