refactor(protocol): slightly change defender monitors #18086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaikocha
approved these changes
Sep 13, 2024
k-kaddal
approved these changes
Sep 13, 2024
k-kaddal
force-pushed
the
slightly_change_protocol_monitors
branch
2 times, most recently
from
8fac56c
to
876dea2
Compare
|
@k-kaddal could you own this PR to make the deployment work? I've add the secrets to our github repo. |
dantaik
commented
Sep 16, 2024
|
I think it will be a good idea to move the monitors to a new package: |
k-kaddal
force-pushed
the
slightly_change_protocol_monitors
branch
3 times, most recently
from
3223b7f
to
7fec512
Compare
k-kaddal
force-pushed
the
slightly_change_protocol_monitors
branch
from
7fec512
to
fdec021
Compare
k-kaddal
force-pushed
the
slightly_change_protocol_monitors
branch
from
74e607a
to
65e5a0e
Compare
k-kaddal
force-pushed
the
slightly_change_protocol_monitors
branch
from
d2dbb76
to
45be49b
Compare
k-kaddal
force-pushed
the
slightly_change_protocol_monitors
branch
from
773486c
to
7ebf46a
Compare
k-kaddal
force-pushed
the
slightly_change_protocol_monitors
branch
from
7ebf46a
to
1be3fe5
Compare
|
Ready to be reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.