Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perf regression when checking for changed content #10234

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

thecrypticace
Copy link
Contributor

We will now track changes in files that are both a context and content dependency in a way that preserves file mod checking optimizations. Technically, we already handle this but the implementation resulted in a significant perf regression that shows up if you scan lots of files (for example: all of node_modules).

See #9787 (comment) for more details.

This allows us to track changes in files that are both a context and content dependency in a way that preserves file mod checking optimizations
@thecrypticace thecrypticace marked this pull request as draft January 3, 2023 20:00
@thecrypticace thecrypticace marked this pull request as ready for review January 3, 2023 20:32
@thecrypticace thecrypticace merged commit ec5136c into master Jan 3, 2023
@thecrypticace thecrypticace deleted the fix/mod-time-optimizations branch January 3, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant