Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure invalid typehints are not generated #5590

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Sep 24, 2021

This PR prevents generating unknown typehints. This is because in a lot of plugins we use the value as-is (any typehint, which is the default).

input:

<div class="inset-[hmm:12px]"></div>

output:

If we didn't have this fix, this would have generated:

output:

.outline-\[hmm\:12px\] {
    outline: hmm: 12px;
}

Which in turn makes the whole css document invalid and it will break your build. No bueno!

@RobinMalfait RobinMalfait merged commit 79b37a8 into master Sep 24, 2021
@RobinMalfait RobinMalfait deleted the ensure-invalid-typehints-are-not-generated branch September 24, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant