Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fit-content utilities for (min/max) height and width #5638

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

lukewarlow
Copy link
Contributor

This PR adds fit-content classes for (min/max) height and width.

I noticed only width seemed to have min or max content utilities currently. I'm not sure why height is missing them but I left it that way to keep this PR focussed. Happy to make a follow up if they are wanted too.

Couldn't find relevant tests for the existing utils for width and height so haven't added any for this. Feel free to point me in the right direction and I can add them.

@adamwathan
Copy link
Member

Looks good thanks! I'm open to adding min/max content utilities in the other places where it makes sense too if you feel like PRing those 👍🏻 Previously we left things out for file size considerations but not a problem anymore.

@samheyman
Copy link

I don't see 'fit-content'. Was this merged and integrated into Tailwind? I had to use w-auto inline-block.

@RobinMalfait
Copy link
Member

@samheyman yes it's there by default. It won't be there if you overrode the values in your tailwind config file so make sure to double check that. Checkout the generated tab at the bottom: https://play.tailwindcss.com/rzPIBlnfH2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants