Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship a new version? #11

Closed
colszowka opened this issue Mar 2, 2016 · 5 comments
Closed

Ship a new version? #11

colszowka opened this issue Mar 2, 2016 · 5 comments

Comments

@colszowka
Copy link
Contributor

Hey there,

thanks for your work on this! I tried out the library and it seems the API changed significantly on master in comparison to 0.1.4 on Rubygems, most notably the examples mentioning create do not work since the method has been renamed from hash. It would be nice to have a new version shipped so the README on the Github landing page actually matches what you get upon installing the lib.

Cheers!

@technion
Copy link
Owner

technion commented Mar 2, 2016

Hi,

There is slight hold up here unfortunately. There is currently a branch in the reference C library that makes major breaking changes, and will definitely require a major version bump. I'm attempting to avoid tagging version 1.0.0 (to address to move to 'create') and then releasing version 2.0.0 a few days later when that gets merged.

For background on the API change you noticed, refer to #9.

I'm definitely aware of this issue - which is why I already bumped version.rb and was literally hours away from shipping it when I came across this issue.

colszowka added a commit to colszowka/ruby-argon2 that referenced this issue Mar 3, 2016
@colszowka
Copy link
Contributor Author

@technion Thanks for the info! I whipped up a tiny PR at #12 that adds a disclaimer note to the README on master

technion added a commit that referenced this issue Mar 3, 2016
Add a note regarding #11 to the README
@technion
Copy link
Owner

technion commented Mar 3, 2016

Thanks! I'll take that PR as a close on this issue. Discussion on the PHC issues page suggests this should hit mainline soon. Note, it breaks literally every test case, so I'll be burning some time importing it.

@technion technion closed this as completed Mar 3, 2016
@colszowka
Copy link
Contributor Author

Thanks for your efforts!

@technion
Copy link
Owner

technion commented Mar 8, 2016

@colszowka I know this is closed but just to update you - I've pulled in the 1.3 algorithm and updated all tests. I'll just give it a few more days while they debate API stabilisation before tagging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants