chore: import order

technote-space · Jun 24, 2022 · 6d5d800 · 6d5d800
1 parent 2d8a3ed
commit 6d5d800
Show file tree

Hide file tree

Showing 6 changed files with 449 additions and 51 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -5,7 +5,8 @@
     "plugin:@typescript-eslint/eslint-recommended"
   ],
   "plugins": [
-    "@typescript-eslint"
+    "@typescript-eslint",
+    "import"
   ],
   "parser": "@typescript-eslint/parser",
   "parserOptions": {
@@ -30,29 +31,6 @@
         "properties": "always"
       }
     ],
-    "require-jsdoc": [
-      "error",
-      {
-        "require": {
-          "FunctionDeclaration": true,
-          "MethodDefinition": true,
-          "ClassDeclaration": true
-        }
-      }
-    ],
-    "valid-jsdoc": [
-      "error",
-      {
-        "requireReturn": false,
-        "preferType": {
-          "String": "string",
-          "Object": "object",
-          "Number": "number",
-          "Function": "function",
-          "Void": "void"
-        }
-      }
-    ],
     "quotes": [
       "error",
       "single",
@@ -71,12 +49,6 @@
         }
       }
     ],
-    "no-magic-numbers": [
-      "error",
-      {
-        "ignoreArrayIndexes": true
-      }
-    ],
     "eqeqeq": "error",
     "block-scoped-var": "error",
     "complexity": [
@@ -85,7 +57,6 @@
         "maximum": 20
       }
     ],
-    "curly": "error",
     "default-case": "error",
     "dot-location": [
       "error",
@@ -102,16 +73,6 @@
         "after": true
       }
     ],
-    "id-length": [
-      "error",
-      {
-        "min": 2,
-        "properties": "never",
-        "exceptions": [
-          "$"
-        ]
-      }
-    ],
     "indent": [
       "error",
       2,
@@ -144,6 +105,12 @@
     ],
     "semi": [
       "error"
-    ]
+    ],
+    "sort-imports": 0,
+    "import/order": [2, {
+      "groups": ["type", "builtin", "external", "internal", "parent", "sibling", "index", "object"],
+      "alphabetize": { "order": "asc", "caseInsensitive": true }
+    }],
+    "@typescript-eslint/no-non-null-assertion": "off"
   }
 }
diff --git a/package.json b/package.json
@@ -53,6 +53,7 @@
     "@typescript-eslint/parser": "^5.29.0",
     "c8": "^7.11.3",
     "eslint": "^8.18.0",
+    "eslint-plugin-import": "^2.26.0",
     "husky": "^8.0.1",
     "lint-staged": "^13.0.3",
     "nock": "^13.2.7",

diff --git a/src/checkLibrary.test.ts b/src/checkLibrary.test.ts
@@ -1,6 +1,6 @@
-import { describe, expect, it } from 'vitest';
 import { existsSync } from 'fs';
 import { join } from 'path';
+import { describe, expect, it } from 'vitest';
 import { BIN_PATH, BIN_FILE } from './constant';
 
 describe('npm check updates', () => {

diff --git a/src/utils/misc.test.ts b/src/utils/misc.test.ts
@@ -1,12 +1,12 @@
 /* eslint-disable no-magic-numbers */
-import { describe, expect, it } from 'vitest';
 import path from 'path';
 import {
   spyOnAddPath,
   addPathCalledWith,
   testEnv,
   generateContext,
 } from '@technote-space/github-action-test-helper';
+import { describe, expect, it } from 'vitest';
 import { getOnlyDefaultBranchFlag, getRunnerArguments } from './misc';
 
 describe('getOnlyDefaultBranchFlag', () => {

diff --git a/src/utils/misc.ts b/src/utils/misc.ts
@@ -1,10 +1,10 @@
-import path from 'path';
 import type { Context } from '@actions/github/lib/context';
-import { Utils, ContextHelper } from '@technote-space/github-action-helper';
 import type { MainArguments } from '@technote-space/github-action-pr-helper/dist/types';
+import type { ExecuteTask, CommandOutput } from '@technote-space/github-action-pr-helper/dist/types';
+import path from 'path';
 import { getInput, addPath } from '@actions/core' ;
+import { Utils, ContextHelper } from '@technote-space/github-action-helper';
 import { ACTION_NAME, ACTION_OWNER, ACTION_REPO, TARGET_NCU_COMMANDS, BIN_PATH, BIN_FILE } from '../constant';
-import type { ExecuteTask, CommandOutput } from '@technote-space/github-action-pr-helper/dist/types';
 
 const { getArrayInput, getBoolValue } = Utils;