added binary based support for kustomize v2 and v3 #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasir-rabbani
force-pushed
the
kustomize-v2-v3-support
branch
from
6dca249
to
54a74d5
Compare
williepaul
reviewed
Aug 14, 2021
pkg/iac-providers/kustomize/v3/testdata/simple-deployment/deployment.yaml
Outdated
Show resolved
Hide resolved
nasir-rabbani
force-pushed
the
kustomize-v2-v3-support
branch
from
54a74d5
to
d1abeb1
Compare
Codecov Report
@@ Coverage Diff @@
## master #988 +/- ##
==========================================
- Coverage 78.46% 78.21% -0.25%
==========================================
Files 231 237 +6
Lines 6255 6289 +34
==========================================
+ Hits 4908 4919 +11
- Misses 1045 1067 +22
- Partials 302 303 +1
|
patilpankaj212
suggested changes
Aug 17, 2021
| ) | ||
|
|
||
| // KustomizeDirectoryLoader implements kustomize directory/file loading | ||
| type KustomizeDirectoryLoader struct { |
There was a problem hiding this comment.
if this struct implements both directory and file loading should the type be KustomizeLoader?
| ) | ||
|
|
||
| var ( | ||
| errLoadIacFileNotSupported = fmt.Errorf("load iac file is not supported for kustomize") |
There was a problem hiding this comment.
I think this error can be exported and used in other packages as well !!
nasir-rabbani
force-pushed
the
kustomize-v2-v3-support
branch
from
d1abeb1
to
a0dd4ce
Compare
patilpankaj212
previously approved these changes
Aug 17, 2021
nasir-rabbani
force-pushed
the
kustomize-v2-v3-support
branch
from
a0dd4ce
to
6d0f45d
Compare
patilpankaj212
previously approved these changes
Aug 19, 2021
nasir-rabbani
force-pushed
the
kustomize-v2-v3-support
branch
from
6d0f45d
to
a67c088
Compare
patilpankaj212
previously approved these changes
Aug 20, 2021
* extract container images from tf iac files * increase kubernetes resource scan coverage * using constants for common strings * adds: extract image ref from tf file * code nits: added comments and removed unwanted variables * adds: extracting containers from aws and azure resources * code nits: added new method for jsoncode type Co-authored-by: Suvarna Rokade <suvarnarokade11@gmail.com>
* inital support for image vulnerability scanning * adds: flag for vul scanning and human readable output support * Adds: unit test cases and code refactoring * made vulnerability methods mockable * adds: documentation for vulnerability scanning * adds: support google artifact registry * updates docs * updates flag message * fixes: tf file image extraction and e2e test Co-authored-by: Cesar Rodriguez <cesar@accurics.com>
cesar-rodriguez
suggested changes
Aug 22, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
cesar-rodriguez
approved these changes
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2andv3.