-
Notifications
You must be signed in to change notification settings - Fork 74.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing input validation on tf.ragged.constant
#55199
Comments
@kanghj In order to expedite the trouble-shooting process ,could you please provide the access to the colab ? Thanks! |
Sorry, my bad, @sushreebarsa. I have updated the access permissions to the colab. Could you try again? https://colab.research.google.com/drive/1OyQNTCiqHKjmHKfYbSOmVt4EfkLEgsNA?usp=sharing |
@gadagashwini I was able to replicate the issue on colab using TF v2.8.0 and tf-nightly , please find the gist here for reference.Thanks! |
Fixes #55199 PiperOrigin-RevId: 442029525
Fixes #55199 PiperOrigin-RevId: 442029525
Fixes #55199 PiperOrigin-RevId: 442029525
Fixes #55199 PiperOrigin-RevId: 442029525
Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information
You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
If I pass an empty list with a large ragged_rank to
tf.ragged.constant
,all RAM is consumed, causing the notebook to crash.
The docs indicate that ragged_rank should be between 0 and the rank of pylist, so the large value of ragged_rank should be rejected
Describe the expected behavior
Some input validation should be done and an exception thrown.
Contributing
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
The colab notebook:
https://colab.research.google.com/drive/1OyQNTCiqHKjmHKfYbSOmVt4EfkLEgsNA?usp=sharing
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
The text was updated successfully, but these errors were encountered: