Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include packages collected by scancode in reports #790

Closed
nishakm opened this issue Aug 19, 2020 · 1 comment · Fixed by #791
Closed

Include packages collected by scancode in reports #790

nishakm opened this issue Aug 19, 2020 · 1 comment · Fixed by #791

Comments

@nishakm
Copy link
Contributor

nishakm commented Aug 19, 2020

Describe the Feature
Currently, the scancode extension only collects file level data even though we also ask it to look for packages

# run scancode against a directory
command = 'scancode -ilpcu --quiet --timeout 300 --json -' <-- p stands for packages

Use Cases
Scancode is a complete static analysis method, so no mounting and and running a process is needed. We can use this method to address #755.

Implementation Changes
The executor needs to collect package information and store it in the packages list for ImageLayer objects.
@nishakm
Copy link
Contributor Author

nishakm commented Aug 19, 2020

@mukultaneja would you be OK with working on this?

@nishakm nishakm mentioned this issue Aug 20, 2020
Merged
yannjor pushed a commit to nokia/tern that referenced this issue Aug 25, 2020
Include packages collected by scancode in reports
f845ac3 
Currently only file data is included when tern is run with the scancode
extension, even though scancode can also detect packages. These changes
add the package information collected by scancode to tern's data model.

Resolves tern-tools#790

Signed-off-by: Yann Jorelle <yann.jorelle@nokia.com>
@yannjor yannjor mentioned this issue Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include packages collected by scancode in reports nokia/tern
1 participant
@nishakm