Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Terraform 0.12 #11

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

bohdanyurov-gl
Copy link

@bohdanyurov-gl bohdanyurov-gl commented Jul 19, 2019

Fixes #9.
Fixes #10

@bohdanyurov-gl
Copy link
Author

image

@bohdanyurov-gl
Copy link
Author

image

@aaron-lane aaron-lane added the enhancement New feature or request label Jul 22, 2019
@aaron-lane aaron-lane changed the title Fixes #9: Add support for Terraform 0.12 Add support for Terraform 0.12 Jul 23, 2019
@aaron-lane aaron-lane self-requested a review July 23, 2019 14:49
README.md Outdated Show resolved Hide resolved
test/ci_integration.sh Outdated Show resolved Hide resolved
test/fixtures/shared/terraform.tfvars Show resolved Hide resolved
test/integration/pubsub_scheduled/inspec.yml Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@bohdanyurov-gl
Copy link
Author

image

Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bohdanyurov-gl. This should be good to merge once the new version of Pub/Sub is released and we update the reference to it.

main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
terraform-google-modules/terraform-google-event-function#20

- Migrated to the new TF 0.12 syntax
- Added type for variables
- Removed instances of unnecessary string interpolation from the code
base
- Removed unnecessary "element" calls
- Run tests locally
- Switched to docker image for terraform 0.12 (version 2.0.0)
- Updated CHANGELOG.md
- Updated README.md, add latest 0.11 release
@aaron-lane aaron-lane changed the base branch from aaron-lane-0.12 to master July 30, 2019 18:31
@aaron-lane aaron-lane merged commit 074443b into terraform-google-modules:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are broken on master Add support for Terraform 0.12
3 participants