Handle nested syn::Type:::Group
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, rustc does not pass the exact original TokenStream to proc-macros in several cases. This has many undesirable effects, such as losing correct location information in error message. See rust-lang/rust#43081 for more details In the future, rustc will begin passing the correct TokenStream to proc-macros. As a result, `syn` may wrap a type in one or more `syn::Type::Group`s (if the proc-macro input came from a `macro_rules!` expansion). I've determined that this can cause `oauth1-request-derive` to fail to match a `Type::Path`. This PR should properly handle nested groups, allowing your crate to work with both old and new input. If you have any questions, feel free to ask me. See rust-lang/rust#72622 for more details.
|
The Rust 1.34.0 failure seems unrelated to this PR - it looks like some dependencies have started relying on features from newer versions of Rust. |
|
@tesaguri: Are there any changes that you'd like me to make? |
|
Sorry for the late reply. I had no time to review this. It looks good to me. Thank you! |
tesaguri
added a commit
that referenced
this pull request
Jun 6, 2020
|
@tesaguri: Thanks! Would you be able to make a new point release? I'd like to roll out the rustc change as soon as possible, but there are several crates on |
|
Published as v0.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, rustc does not pass the exact original TokenStream to
proc-macros in several cases. This has many undesirable effects, such as
losing correct location information in error message.
See rust-lang/rust#43081 for more details
In the future, rustc will begin passing the correct TokenStream to
proc-macros. As a result,
synmay wrap a type in one or moresyn::Type::Groups (if the proc-macro input came from amacro_rules!expansion).I've determined that this can cause
oauth1-request-deriveto fail to matcha
Type::Path. This PR should properly handle nested groups, allowingyour crate to work with both old and new input.
If you have any questions, feel free to ask me. See rust-lang/rust#72622
for more details.